Add test coverage for ClosureReason::DisconnectedPeer
#1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1471 +/- ##
=======================================
Coverage 90.92% 90.92%
=======================================
Files 75 75
Lines 41842 41863 +21
Branches 41842 41863 +21
=======================================
+ Hits 38043 38064 +21
Misses 3799 3799
Continue to review full report at Codecov.
|
TheBlueMatt
previously approved these changes
May 9, 2022
tnull
previously approved these changes
May 9, 2022
Add test that ensures that channels are closed with `ClosureReason::DisconnectedPeer` if the peer disconnects before the funding transaction has been broadcasted.
ViktorTigerstrom
dismissed stale reviews from tnull, vincenzopalazzo, and TheBlueMatt
via
7f0aa93
ViktorTigerstrom
force-pushed
the
2022-05-test-disconnected-before-funding-broadcasted
branch
from
a74df15 to
7f0aa93
Compare
|
Noticed that I had managed to add an extra blank line before the test, and fixed a small grammar error. Sorry about that! |
valentinewallace
approved these changes
May 9, 2022
TheBlueMatt
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1431.
Add test that ensures that channels are closed with
ClosureReason::DisconnectedPeerif the peer disconnects before thefunding transaction has been broadcasted.
Let me know if the test should be extended with the scenario that
nodes[0]can still close the channel withClosureReason::DisconnectedPeerifnodes[1]disconnects, even after theFundingSignedmsg has sent bynodes[1]as long asnodes[0]::handle_funding_signedhasn't been executed.