Move trait bounds on wire::Type from use to the trait itself
#1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wire::Type` is only (publicly) used as the `CustomMessage` associated type in `CustomMessageReader`, where it has additional trait bounds on `Debug` and `Writeable`. The documentation for `Type` even mentions that you need to implement `Writeable` because this is the one place it is used. To make this more clear, we move the type bounds onto the trait itself and not on the associated type. This is also the only practical way to build C bindings for `Type` as we cannot have a concrete, single, `Type` struct in C which only optionally implements various subtraits, at least not without runtime checking of the type bounds.
jkczyz
approved these changes
Sep 22, 2021
valentinewallace
approved these changes
Sep 22, 2021
Codecov Report
@@ Coverage Diff @@
## main #1092 +/- ##
=======================================
Coverage 90.73% 90.73%
=======================================
Files 65 65
Lines 34315 34315
=======================================
+ Hits 31134 31136 +2
+ Misses 3181 3179 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wire::Typeis only (publicly) used as theCustomMessageassociated type in
CustomMessageReader, where it has additionaltrait bounds on
DebugandWriteable. The documentation forTypeeven mentions that you need to implementWriteablebecausethis is the one place it is used.
To make this more clear, we move the type bounds onto the trait
itself and not on the associated type.
This is also the only practical way to build C bindings for
Typeas we cannot have a concrete, single,
Typestruct in C which onlyoptionally implements various subtraits, at least not without
runtime checking of the type bounds.
Gonna need this for 0.0.101 bindings due to the above.