Adds Txid to lighting-block-sync::convert #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
+ Coverage 90.80% 90.81% +0.01%
==========================================
Files 61 65 +4
Lines 31582 32843 +1261
==========================================
+ Hits 28678 29828 +1150
- Misses 2904 3015 +111
Continue to review full report at Codecov.
|
jkczyz
reviewed
Aug 6, 2021
lightning-block-sync/src/convert.rs
Outdated
Comment on lines
159
to
182
| impl TryInto<Txid> for JsonResponse { | ||
| type Error = std::io::Error; | ||
| fn try_into(self) -> std::io::Result<Txid> { | ||
| match self.0.as_str() { | ||
| None => Err(std::io::Error::new( | ||
| std::io::ErrorKind::InvalidData, | ||
| "expected JSON string", | ||
| )), | ||
| Some(hex_data) => match Vec::<u8>::from_hex(hex_data) { | ||
| Err(_) => Err(std::io::Error::new( | ||
| std::io::ErrorKind::InvalidData, | ||
| "invalid hex data", | ||
| )), | ||
| Ok(txid_data) => match encode::deserialize(&txid_data) { | ||
| Err(_) => Err(std::io::Error::new( | ||
| std::io::ErrorKind::InvalidData, | ||
| "invalid txid", | ||
| )), | ||
| Ok(txid) => Ok(txid), | ||
| }, | ||
| }, | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Looks like you need tabs not spaces. Likewise in the tests.
sr-gi
force-pushed
the
add-txid-convert
branch
from
1224597 to
f65d05c
Compare
|
@jkczyz @valentinewallace should be good now. |
jkczyz
approved these changes
Aug 24, 2021
valentinewallace
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
TryInto<Txid> for JsonResponse.Related to lightningdevkit/ldk-sample#28 (see lightningdevkit/ldk-sample#28 (comment)).