Skip to content

Include expiry in invoices #1411

@jkczyz

Description

@jkczyz

When creating an Invoice using functions in the lightning-invoice crate's utils module, the invoice expiration is not set. It should be set with the value encoded in the provided payment secret. Otherwise, BOLT 11 defines the default expiry to be 1 hour whereas ChannelManager will use whatever value is encoded in the payment secret.

This may be tricky because either the methods will need to take in a ChannelManager to verify the payment secret and extract the expiry or the expiry needs to be passed in but could potentially not match what's encoded in the payment secret.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions