Initial draft of blockchain data guide #3
Merged
+190
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
force-pushed
the
2021-02-blockdata
branch
2 times, most recently
from
c00ee36 to
31bb66d
Compare
TheBlueMatt
reviewed
Feb 3, 2021
TheBlueMatt
reviewed
Feb 3, 2021
arik-so
reviewed
Feb 3, 2021
docs/blockdata.md
Outdated
| accordingly. It supports receiving either full blocks or pre-filtered blocks. | ||
| Block data can sourced from anywhere, but it is your responsibility to ensure | ||
| that the necessary `block_connected` and `block_disconnected` methods are called | ||
| on `ChannelManager` and `ChainMonitor`. |
There was a problem hiding this comment.
Should there be an explanation in parentheses why it needs to be called on both? I think this might confuse people and cause questions such as in what sequence.
There was a problem hiding this comment.
Added a short statement about these.
@TheBlueMatt I can't recall if the ordering matters anymore. Our test fail if I reorder them, but that may just be brittleness.
arik-so
reviewed
Feb 3, 2021
arik-so
reviewed
Feb 3, 2021
valentinewallace
approved these changes
Feb 3, 2021
arik-so
approved these changes
Feb 3, 2021
jkczyz
force-pushed
the
2021-02-blockdata
branch
from
65c373d to
0eab9ec
Compare
jkczyz
force-pushed
the
2021-02-blockdata
branch
from
0eab9ec to
df908d5
Compare
arik-so
approved these changes
Feb 3, 2021
|
lgtm! |
DanGould
added a commit
to DanGould/lightningdevkit.org
that referenced
this pull request
May 23, 2024
…roadmap-link chore(fix): typo and roadmap redirection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.