Skip to content

Use marker inside macros in *Enabled methods #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2018
Merged

Use marker inside macros in *Enabled methods #140

merged 1 commit into from
Dec 6, 2018

Conversation

eugeniyk
Copy link
Contributor

@eugeniyk eugeniyk commented Dec 6, 2018

@girishsubramanyam
Copy link
Contributor

@analytically Please take a look at this PR and merge if it looks good.

@analytically analytically merged commit 4c99314 into lightbend-labs:master Dec 6, 2018
@eugeniyk eugeniyk deleted the use-marker-in-validation branch December 10, 2018 15:00
@analytically
Copy link
Collaborator

Seems like this breaks 2.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@analytically analytically analytically approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add marker variable to is*Enabled macros
3 participants
@eugeniyk @girishsubramanyam @analytically