Skip to content

remove error_buffer_copy #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ All notable changes to `:vips` will be documented in this file.

## master

- remove unused vips_error_buffer_copy() declaration to fix compatibility with
libvips before 8.9 [Waschnick]
- refactor callBase() for maintainability
- work around a php-ffi memory leak in getPspec() [levmv]
- work around a php-ffi memory leak in arrayType()
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ to your `composer.json`:

php-vips does not yet support preloading, so you need to enable FFI globally.
This has some security implications, since anyone who can run php on your
server can use it to make calls off into any native library they can find.
server can use it to call any native library they have access to.

Of course if attackers are running their own PHP code on your webserver you
are probably already toast, unfortunately.
Expand Down
1 change: 0 additions & 1 deletion src/FFI.php
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,6 @@ private static function init(): void
int vips_shutdown (void);

const char *vips_error_buffer (void);
char *vips_error_buffer_copy (void);
void vips_error_clear (void);
void vips_error_freeze (void);
void vips_error_thaw (void);
Expand Down