-
Notifications
You must be signed in to change notification settings - Fork 37
Use const parameters in mir.format to reduce template bloat #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ready now. |
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
==========================================
- Coverage 92.64% 92.64% -0.01%
==========================================
Files 62 62
Lines 15380 15376 -4
==========================================
- Hits 14249 14245 -4
Misses 1131 1131
Continue to review full report at Codecov.
|
Ready now, @9il. |
|
|
374686e
to
5bfcfd0
Compare
I reverted the changes in |
5bfcfd0
to
65d74ba
Compare
I used string text(string separator = "", Args...)(auto ref const(Args) args) instead. It fulfills the purpose of reducing template bloat aswell. Note that string text(string separator = "", Args...)(auto ref const Args args) fails with a scope error so I scratched that. I'm not sure how that is different but that doesn't matter for this PR. |
b23a5be
to
65d74ba
Compare
0d0c265
to
8e55e34
Compare
Ready now. |
Does text or print make use of |
Yes. |
The important changes are the qualifications of the parameters to the
text
andprint
overloads which in essence strips off eitherconst
orimmutable
qualifier from the type(s)A
. In calls such asall result in the same template instance of
text
potentially saving time and space requirements on compilation and binary sizes.