Skip to content

'certificate' parameter in RemoteCallbacks doesn't work #945

Closed
@nu11ptr

Description

@nu11ptr

Looking at the code, I think the 'certificate' init param is supposed to be named 'certificate_check' so that if it is set, it overrides the class function (I believe this is how 'credentials' is working). As it stands, I don't see anywhere in the class where 'certficate' is referenced (fetch_opts it only references 'certificate_check') and some tests to self-signed servers didn't work until I created my own subclass with my own version of 'certificate_check'.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions