No more check function #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love some eyes on this @nulltoken. Want to make sure it is sane before I merge it, squash down the register filter PR, and update libgit2 to the latest 💅 |
|
|
||
| this.name = name; | ||
| this.attributes = attributes; | ||
| var attributesAsString = string.Join(",", this.attributes.Select(attr => attr.FilterDefinition)); |
There was a problem hiding this comment.
Nit: Just use the linq inside the initializer list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need to supply the check callback when registering a Filter with the library.
For example if you want to install a filter with libgit2 with the name
fooyou would register that filter with libgit2sharp and it would be applied to any file that matched the path spec found in the gitattributes file. For example*.txt filter=fooI naively thought that we needed to implement custom check logic for filters (the piece that actually matches the entry in the attributes file to the file being filtered) but it turns out this is already implemented in libgit2 https://github.com/libgit2/libgit2/blob/master/src/filter.c#L403 and if we simply do not provide the optional check callback, everything just works ™️
I've added an object
FilterAttributewhich allows you to define and register a filter in the correct formatfilter=name