Failure to create branch

[jamill]

When creating a branch with a name that matches the namespace of a previously deleted branch, branch creation will fail with:

Could not open .../.git/logs/refs/heads/level_one for writing: Access is denied

at LibGit2Sharp.Core.Ensure.HandleError(Int32 result) in LibGit2Sharp\Core\Ensure.cs:line 126
at LibGit2Sharp.Core.Ensure.ZeroResult(Int32 result) in LibGit2Sharp\Core\Ensure.cs:line 144
at LibGit2Sharp.Core.Proxy.git_branch_create(RepositorySafeHandle repo, String branch_name, ObjectId targetId, Boolean force, Signature signature, String logMessage) in LibGit2Sharp\Core\Proxy.cs:line 155
at LibGit2Sharp.BranchCollection.Add(String name, Commit commit, Signature signature, String logMessage, Boolean allowOverwrite) in LibGit2Sharp\BranchCollection.cs:line 128
at LibGit2Sharp.BranchCollection.Add(String name, Commit commit, Boolean allowOverwrite) in LibGit2Sharp\BranchCollection.cs:line 143
at LibGit2Sharp.Tests.BranchFixture.CanCreateBranchInDeletedNestedBranchNamespace() in LibGit2Sharp.Tests\BranchFixture.cs:line 877

The scenario is:

git branch level_one/level_two
git branch -D level_one/level_two
git branch level_one

While a bit of a corner case - people sometimes do this and git.git handles this without issue. My thought is that this should probably be handled better in git_branch_create, but I will start with an issue and failing test case here.

/cc @ethomson @carlosmn

[dahlbyk]

My thought is that this should probably be handled better in git_branch_create

👍

[carlosmn]

The error is then presumably because refs/heads/level_one/ is left by the deleter. I think it's its responsibility to delete, but I suppose we're the same process here so there might be two different bugs here. One failing to remove the directories when they're empty and another failing to delete them to make space for the new reference (assuming git also does the latter).

[dahlbyk]

The error is then presumably because refs/heads/level_one/ is left by the deleter. I think it's its responsibility to delete

git.git leaves level_one/ behind, only deleting it on git branch level_one

[nulltoken]

Rebased