Adds support for nCrunch. #825
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,3 +39,4 @@ _ReSharper*/ | |
| LibGit2Sharp/Core/UniqueIdentifier.cs | ||
|
|
||
| !Lib/NativeBinaries/*/*.pdb | ||
| _NCrunch_LibGit2Sharp/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <ProjectConfiguration> | ||
| <BuildPriority>1000</BuildPriority> | ||
| <CopyReferencedAssembliesToWorkspace>false</CopyReferencedAssembliesToWorkspace> | ||
| <ConsiderInconclusiveTestsAsPassing>true</ConsiderInconclusiveTestsAsPassing> | ||
| <PreloadReferencedAssemblies>false</PreloadReferencedAssemblies> | ||
| <AllowDynamicCodeContractChecking>true</AllowDynamicCodeContractChecking> | ||
| <AllowStaticCodeContractChecking>false</AllowStaticCodeContractChecking> | ||
| <AllowCodeAnalysis>false</AllowCodeAnalysis> | ||
| <IgnoreThisComponentCompletely>false</IgnoreThisComponentCompletely> | ||
| <RunPreBuildEvents>false</RunPreBuildEvents> | ||
| <RunPostBuildEvents>false</RunPostBuildEvents> | ||
| <PreviouslyBuiltSuccessfully>true</PreviouslyBuiltSuccessfully> | ||
| <InstrumentAssembly>true</InstrumentAssembly> | ||
| <PreventSigningOfAssembly>false</PreventSigningOfAssembly> | ||
| <AnalyseExecutionTimes>true</AnalyseExecutionTimes> | ||
| <DetectStackOverflow>true</DetectStackOverflow> | ||
| <IncludeStaticReferencesInWorkspace>true</IncludeStaticReferencesInWorkspace> | ||
| <DefaultTestTimeout>60000</DefaultTestTimeout> | ||
| <UseBuildConfiguration></UseBuildConfiguration> | ||
| <UseBuildPlatform></UseBuildPlatform> | ||
| <ProxyProcessPath></ProxyProcessPath> | ||
| <UseCPUArchitecture>AutoDetect</UseCPUArchitecture> | ||
| <MSTestThreadApartmentState>STA</MSTestThreadApartmentState> | ||
| <BuildProcessArchitecture>x86</BuildProcessArchitecture> | ||
| <IgnoredTests> | ||
| <NamedTestSelector> | ||
| <TestName>LibGit2Sharp.Tests.ShadowCopyFixture.CanProbeForNativeBinariesFromAShadowCopiedAssembly</TestName> | ||
| </NamedTestSelector> | ||
| </IgnoredTests> | ||
| <AdditionalFilesToInclude>Resources\**;Resources\**.*</AdditionalFilesToInclude> | ||
|
There was a problem hiding this comment. Why do we need both paths? Couldn't this be only? There was a problem hiding this comment. Some of the resources don't have an extension. If you ignore Resources*. it will only ignore resources that have a |
||
| </ProjectConfiguration> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <SolutionConfiguration> | ||
| <FileVersion>1</FileVersion> | ||
| <InferProjectReferencesUsingAssemblyNames>false</InferProjectReferencesUsingAssemblyNames> | ||
| <AllowParallelTestExecution>false</AllowParallelTestExecution> | ||
| <AllowTestsToRunInParallelWithThemselves>false</AllowTestsToRunInParallelWithThemselves> | ||
| <FrameworkUtilisationTypeForNUnit>UseDynamicAnalysis</FrameworkUtilisationTypeForNUnit> | ||
| <FrameworkUtilisationTypeForGallio>UseStaticAnalysis</FrameworkUtilisationTypeForGallio> | ||
| <FrameworkUtilisationTypeForMSpec>UseStaticAnalysis</FrameworkUtilisationTypeForMSpec> | ||
| <FrameworkUtilisationTypeForMSTest>UseStaticAnalysis</FrameworkUtilisationTypeForMSTest> | ||
| <FrameworkUtilisationTypeForXUnitV2>UseStaticAnalysis</FrameworkUtilisationTypeForXUnitV2> | ||
| <MetricsExclusionList> | ||
| </MetricsExclusionList> | ||
| </SolutionConfiguration> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| <ProjectConfiguration> | ||
| <BuildPriority>1000</BuildPriority> | ||
| <CopyReferencedAssembliesToWorkspace>false</CopyReferencedAssembliesToWorkspace> | ||
| <ConsiderInconclusiveTestsAsPassing>false</ConsiderInconclusiveTestsAsPassing> | ||
| <PreloadReferencedAssemblies>false</PreloadReferencedAssemblies> | ||
| <AllowDynamicCodeContractChecking>true</AllowDynamicCodeContractChecking> | ||
| <AllowStaticCodeContractChecking>false</AllowStaticCodeContractChecking> | ||
| <AllowCodeAnalysis>false</AllowCodeAnalysis> | ||
| <IgnoreThisComponentCompletely>false</IgnoreThisComponentCompletely> | ||
| <RunPreBuildEvents>false</RunPreBuildEvents> | ||
| <RunPostBuildEvents>false</RunPostBuildEvents> | ||
| <PreviouslyBuiltSuccessfully>true</PreviouslyBuiltSuccessfully> | ||
| <InstrumentAssembly>true</InstrumentAssembly> | ||
| <PreventSigningOfAssembly>false</PreventSigningOfAssembly> | ||
| <AnalyseExecutionTimes>true</AnalyseExecutionTimes> | ||
| <DetectStackOverflow>true</DetectStackOverflow> | ||
| <IncludeStaticReferencesInWorkspace>true</IncludeStaticReferencesInWorkspace> | ||
| <DefaultTestTimeout>60000</DefaultTestTimeout> | ||
| <UseBuildConfiguration></UseBuildConfiguration> | ||
| <UseBuildPlatform></UseBuildPlatform> | ||
| <ProxyProcessPath></ProxyProcessPath> | ||
| <UseCPUArchitecture>AutoDetect</UseCPUArchitecture> | ||
| <MSTestThreadApartmentState>STA</MSTestThreadApartmentState> | ||
| <BuildProcessArchitecture>x86</BuildProcessArchitecture> | ||
| <AdditionalFilesToInclude>..\Lib\NativeBinaries\**.*</AdditionalFilesToInclude> | ||
| </ProjectConfiguration> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please share some information about what led to ignoring this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Behind the scenes, NCrunch builds everything out into separate folders and the runner has a custom assembly resolver for locating assemblies on disk. It does not use the CLR's built in assembly resolver. After getting all other tests passing, this was the only one that wasn't passing. The name of this test suggests to me that it is testing the behavior of LibGit2Sharp under a very specific circumstances (shadow copying by the CLR). I assumed (based on the test name) that it was unlikely to work correctly under NCrunch due to the way NCrunch does assembly resolution so I ignored it.
It may be possible to get the test running under NCrunch, but my thought was that it probably wasn't worth the time investment required for a single test.
Personally I am pretty loose with NCrunch test ignores. Whatever build server I have usually runs all of the tests anyway, NCrunch is there as a convenience for getting a tighter feedback loop. If one test is missing from NCrunch runs it isn't a big deal to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough