-
Notifications
You must be signed in to change notification settings - Fork 899
FileStatus names #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileStatus names #527
Conversation
The more I think about this, the more it makes sense to me. 👍 to reuse CamelCased version of libgit2 enum (which also more or less match with git documentation) |
Seems like an improvement to me |
Labeled as |
Ready for review |
@Therzok Very strange Mono failure in this build log
|
Not sure what caused it. Seems to be mono 4. I think something got fixed regarding this in 4.1. |
/// </summary> | ||
TypeChangeInWorkdir = (1 << 10), /* GIT_STATUS_WT_TYPECHANGE */ | ||
|
||
/// <summary> | ||
/// The file has been renamed in the working directory. The previous version at the previous name exists in the Index. | ||
/// </summary> | ||
RenamedInWorkDir = (1 << 11), /* GIT_STATUS_WT_RENAMED */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a minor issue, but the all other names have 'dir' (lowercase d) while here is uppercased 'Dir'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbialobr Good catch! Fixed
Published as NuGet pre-release package |
Current FileStatus names are missleading. To get know what they actually stands for, you have to read the doco. I like names that apear in ligbit2. When I see such name I know that state describes change made to INDEX or WorkingTree.
We can drop
GIT_STATUS_
prefix as they are members of FileStatus.I would only use
Unmodified
instead ofCurrent