Skip to content

Remove Tag from TreeEntryTargetType enum #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2013
Merged

Remove Tag from TreeEntryTargetType enum #433

merged 2 commits into from
May 13, 2013

Conversation

martinwoodward
Copy link
Member

Not completely sure if we should just remove this or if @nulltoken was trolling me when we said he wanted it obsoleted. Obsoleting for now, we can just remove later.

@@ -21,6 +21,7 @@ public enum TreeEntryTargetType
/// <summary>
/// An annotated tag object.
/// </summary>
[Obsolete("Not a valid TreeEntryTargetType")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the deprecation message into "This entry will be removed in the next release as it is not a valid TreeEntryTargetType."?

@martinwoodward
Copy link
Member Author

My implant makes kicks in when I try to promise to do things in the future that I can't guarantee ;-) Said we'll be removing it "soon", how about that?

@dahlbyk
Copy link
Member

dahlbyk commented May 13, 2013

Compromise: including the removal as a separate commit in this PR so @nulltoken can merge all but the removal for now, and close the PR completely after the next release.

@nulltoken
Copy link
Member

Said we'll be removing it "soon", how about that?
Well, "in the next release" is pretty standard pattern. And we always held to our promises ;-) See #181 and #400.

The plan is to release this PR in v0.11.1 (as soon as #430 is merged).
Once v0.11.1 is tagged and published, we drop the [Obsolete] decoration. When v0.12 is released, the enum entry is already dropped.

@nulltoken nulltoken merged commit c000936 into libgit2:vNext May 13, 2013
@nulltoken
Copy link
Member

💖

Now, if you feel like it you can initiate another pull request to get rid of the deprecated entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants