Libgit2 update - WIP #259
Closed
Libgit2 update - WIP #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements git clean and exposes the ability to remove untracked files from the working directory. If / when git clean functionality is exposed directly by libgit2, we can update this to use that entry point. Currently, we call git_checkout_index with a flags indicating that untracked entries should be removed. This does not support other flags exposed by core Git, such as removing ignored files.
Checkout tests were originally written under the assumption that git reset would remove untracked files (reset, as implemented in LibGit2Sharp, originally mistakenly removed untracked files). This updates the tests to reset and clean the working directory.
|
All the work is being done on #260 now - closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to bring libgit2 binaries forward in LibGit2Sharp. There is still one failing test (HardResetUpdatesTheContentOfTheWorkingDirectory) - but we will need libgit2 updates to fix this properly.
Most of the content of this PR comes from @nulltoken, which I brought into this commit.
@ben - We can use this to fix (most) of the issues when doing the reaction work in response to the "The Great Renaming".