Clean untracked files from working directory #253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements git clean and exposes the ability to remove untracked files from the working directory. If / when git clean functionality is exposed directly by libgit2, we can update this to use that entry point. Currently, we call git_checkout_index with a flags indicating that untracked entries should be removed. This does not support other flags exposed by core Git, such as removing ignored files.
Checkout tests were originally written under the assumption that git reset would remove untracked files (reset, as implemented in LibGit2Sharp, originally mistakenly removed untracked files). This updates the tests to reset and clean the working directory.
|
Included with PR #260. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current checkout tests rely on
Resetto update the tracked and untracked files in a working directory. However, proper behavior is forResetto only modify the tracked files. This PR:Some other thoughts:
CleanWorkingDirectoryimplemented on theIndexclass, but I could see this exposed off of theRepositoryclass as well, which is where some other methods that impact both the index and the working directory exist (e.g.Reset).git_checkout_indexwith a parameter indicating that it should remove untracked files. This means that not all the coregit cleanoptions are supported, such as removing ignored files as well. If there are other cases where cleaning withgit_checkout_indexdoes not behave as we want here, please bring them up as well.