Skip to content

Package updates #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 13, 2018
Merged

Package updates #1602

merged 11 commits into from
Sep 13, 2018

Conversation

bording
Copy link
Member

@bording bording commented Aug 25, 2018

Also includes a minor tweak to the editorconfig file.

@bording bording requested a review from ethomson August 25, 2018 01:38
@ethomson
Copy link
Member

With the travis update to require a newer .NET Core, am I right in thinking that we are now no longer .NET Core 2.0 compatible? What's pushing that requirement? What is the fallout from that?

@bording
Copy link
Member Author

bording commented Aug 25, 2018

The reason for that is to get a newer SDK, which is needed for the switch to Microsoft.SourceLink.GitHub.

That has no impact on the compatibility of the library. That's determined by the TFMs we target, which hasn't changed. The library is still netstandard2.0.

@bording
Copy link
Member Author

bording commented Aug 25, 2018

It appears that all of the AppVeyor builds on the libgit2 account are getting stuck at being queued, but never actually run.

I've opened https://help.appveyor.com/discussions/problems/16035-queued-builds-never-start, so hopefully they'll be able to fix the problem.

@bording
Copy link
Member Author

bording commented Aug 27, 2018

AppVeyor fixed the problem with the build queue!

@ethomson
Copy link
Member

Yep, makes sense. Thanks @bording.

@ethomson ethomson merged commit c847aad into master Sep 13, 2018
@bording bording deleted the package-updates branch September 13, 2018 14:54
alex-weaver pushed a commit to alex-weaver/libgit2sharp that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants