Update Dependencies #1509
Update Dependencies #1509
Conversation
Xunit 2.3 now considers it an error to pass a integer type when a enum was expected.
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Update="Nerdbank.GitVersioning" Version="2.0.41" /> |
There was a problem hiding this comment.
This is currently in the Directory.Build.props file, so we should either update that one entry, or remove it if we want it in the project files after all.
| @@ -34,10 +34,14 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="LibGit2Sharp.NativeBinaries" Version="[1.0.185]" PrivateAssets="contentFiles" /> | |||
| <PackageReference Include="SourceLink.Create.GitHub" Version="2.2.0" PrivateAssets="all" /> | |||
| <PackageReference Include="SourceLink.Create.GitHub" Version="2.5.0" PrivateAssets="all" /> | |||
| <DotNetCliToolReference Include="dotnet-sourcelink-git" Version="2.2.0" /> | |||
There was a problem hiding this comment.
The DotNetCliToolReference also needs to be bumped to 2.5.0.
| <DotNetCliToolReference Include="dotnet-sourcelink-git" Version="2.2.0" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Update="Nerdbank.GitVersioning" Version="2.0.41" /> |
There was a problem hiding this comment.
Same as above. This is already in the Directory.Build.props file.
I'd say there's an argument that we don't need it there, since this is the only project that actually cares about the version, and having it in the props file means it applies to the test project as well.
If we do keep it here instead, the extra ItemGroup should be removed and it should go up with the other packages above. It also needs PrivateAssets="all" added.
| @@ -34,10 +34,14 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="LibGit2Sharp.NativeBinaries" Version="[1.0.185]" PrivateAssets="contentFiles" /> | |||
There was a problem hiding this comment.
We should go ahead and build a new native binaries package that we can update to as well. 1.0.185 doesn't have all of the changes I made around support netstandard.
|
Superseded by #1511 |
The current version of xunit's Visual Studio integration has been incredibly flaky on my machines. So far, the Xunit 2.3 betas have been much more stable. Now that there's a proper Xunit version, let's upgrade our dependencies to use it.