Use Travis' csharp language setup #1300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/travis-csharp
branch
from
4dbb815 to
3ec31d6
Compare
carlosmn
changed the title
Use the configuration Travis already knows about to reduce how much custom code we're running. As it's now easy to do, test on both 3.12 and 4.2 versions of mono. This also has the advantage of making us test on both systems with the same version.
carlosmn
force-pushed
the
cmn/travis-csharp
branch
from
3ec31d6 to
85ad800
Compare
|
This seems like it's working. We build with 3.12 so we support those who can't upgrade for whatever reason, but also with 4.2 so we build with something recent. It also unifies which versions we test on which OS, which was different between Ubuntu and OS X. @ethomson thoughts? |
|
This is really delightful. Thanks for tackling this. And thanks @FeodorFitsner for making this so easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the configuration Travis already knows about to reduce how much
custom code we're running.
As it's now easy to do, test on both 3.12 and 4.2 versions of mono. This
also has the advantage of making us test on both systems with the same
version.
This fixes #1032, fixes #1082, supersedes #1086, supersedes #1129