Add a RemoteName property to avoid lookups #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <see cref="Remote"/> to fetch from and push to. If this is a | ||
| /// remote-tracking branch, this will return the remote containing | ||
| /// the tracked branch. If there no tracking information this will | ||
| /// return null. |
There was a problem hiding this comment.
This should not say it returns a remote but its name.
|
Let's deprecate the |
Sometimes all you need is the name and right now there's no way of getting it short of git_remote_lookup. While going through a lookup guarantees that the remote exists that shouldn't be the concern of the Branch, it should just let the caller know what's been configured as it's remote.
niik
force-pushed
the
branch-remote-name
branch
from
8b426af to
9a408b9
Compare
Done |
carlosmn
added a commit
that referenced
this pull request
Mar 22, 2016
Add a RemoteName property to avoid lookups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes all you need is the name and right now there's no way of getting it short of
git_remote_lookup. While going through a lookup guarantees that the remote exists that shouldn't be the concern of theBranch, it should just let the caller know what's been configured as it's remote.cc @carlosmn We could/should ditch the
Remoteproperty here IMO seeing how it's disposable now and have callers to go throughRepository.Remotescc @ethomson