Remove equality comparison from Remote #1286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
There are no semantics for determining whether a remote is like another one. The equality decision in libgit2sharp only looks at the name and urls, ignoring any other number of fields which affect how a remote behaves. For these reaons, rip it out. Equality (in as much as it's valuable) should be perform on whatever aspect the code is interested.
carlosmn
force-pushed
the
cmn/remote-no-equal
branch
from
317aac8 to
92b55d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no semantics for determining whether a remote is like another
one. The equality decision in libgit2sharp only looks at the name and
urls, ignoring any other number of fields which affect how a remote
behaves.
For these reaons, rip it out. Equality (in as much as it's valuable)
should be perform on whatever aspect the code is interested.
If there's a way to deprecate the implementation of an interface I'm all ears, but it looks like we might want to simply get rid of it.