Don't load an object just to check its ID #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/equality-over-id
branch
from
47bfd33 to
8b2c987
Compare
In order to check for equality we just need to compare the ID of the object. We do not need to look up the object but can compare their identifiers directly. This also requires us to modify Branch's check for the current branch, but the new code more accurately reflects the check we do want to perform. Namely whether HEAD points to our reference name.
carlosmn
force-pushed
the
cmn/equality-over-id
branch
from
8b2c987 to
840422d
Compare
ethomson
pushed a commit
that referenced
this pull request
Mar 9, 2016
Don't load an object just to check its ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to check for equality we just need to compare the ID of the
object. We do not need to look up the object but can compare their
identifiers directly.