Expose the Minimal diff algorithm #1227
Merged
+9
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
Minimal
diff algorithm and uses it if specified when doing a diff, fixing #1057.Unfortunately it's difficult to find an example which produces a different diff output for the
Meyers
andMinimal
algorithm, so I don't have a unit test to check 1dd11be. It looks like the libgit code suffered the same problem and only test that output from patience differs from the default, which is already checked inUsingPatienceAlgorithmCompareOptionProducesPatienceDiff
.The change could be tested by extracting a class from
Diff.BuildOptions
and checking that theGitDiffOptions
returned have the correct flags set, but that does break the encapsulation slightly. I'm happy to make that change if you want though.