WriteStream: use libgit2's error when we fail to write to the next stream #1107
Conversation
| @@ -53,9 +53,10 @@ public override void Write(byte[] buffer, int offset, int count) | |||
| { | |||
| fixed (byte* bufferPtr = &buffer[offset]) | |||
| { | |||
| if (nextStream.write(nextPtr, (IntPtr)bufferPtr, (UIntPtr)count) < 0) | |||
| int ret = nextStream.write(nextPtr, (IntPtr)bufferPtr, (UIntPtr)count); | |||
| if (ret < 0) | |||
There was a problem hiding this comment.
Is write ever expected to return a positive number? If not, we can skip this check here.
There was a problem hiding this comment.
Or use Ensure.Int32Result(ret).
And FWIW, we typically use res rather than ret.
There was a problem hiding this comment.
Ah yes, I'd missed that, that's the function we should use.
|
Does it matter if we check |
|
It shouldn't particularly matter whether we do it inside or not, all it's doing is askiing the GC not to move something to which the caller has a reference, so it shouldn't be touching it; but it does seem good form to keep the fixed block to be as small as possible. |
carlosmn
force-pushed
the
cmn/ensure-next-stream
branch
from
3c88b78 to
ce5db5e
Compare
| @@ -51,14 +51,14 @@ public override void Write(byte[] buffer, int offset, int count) | |||
| { | |||
| unsafe | |||
| { | |||
| int res; | |||
There was a problem hiding this comment.
Have to define this outside the unsafe
carlosmn
force-pushed
the
cmn/ensure-next-stream
branch
from
ce5db5e to
a6dccd1
Compare
|
👍 assuming we're green |
|
👍 |
WriteStream: use libgit2's error when we fail to write to the next stream
|
👍 |
This should let us see what libgit2 thinks the problem is when we fail to pass the data forward.
#1030 (comment)