Test coverage for branch-only submodule #1051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, need reflog for standard repo tests. |
|
@dahlbyk 🆒 |
|
Sure, what do you have in mind? |
|
Maybe squash the last two commits together as the first one doesn't build by itself? |
|
@dahlbyk ping? |
|
Better? |
|
@nulltoken @dahlbyk I will look at this, but today I'm heads down on something else. Can we wait until tomorrow? |
|
LGTM @dahlbyk 🙇 thanks! |
nulltoken
added a commit
that referenced
this pull request
Jun 19, 2015
Test coverage for branch-only submodule
|
🚢'd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proves that #604 is fixed.
Also:
difftoResources/.gitattributesfor commonly-modified text files - respected locally even if GitHub seems to ignore.gitattributes.remote.origin.urlrelative in allsubmodule_wd/.git/modules.info/exclude) - fewer files to copy = faster tests.