Skip to content

Filter Support Redux #1025

Closed
Closed
@shiftkey

Description

@shiftkey

So we currently have #854 in-flight which was paused due to the work upstream in libgit2/libgit2#2911 to add in streaming filter support.

I've grabbed this PR, rebased it on top of vNext and am working through the necessary changes. Once I'm happy with the passing tests, I'll grab some of @ammeep's time to get a 👍 and she can finish up this PR.

Anyway, a couple of questions while I'm working through tests:

  • the proxy method for git_buf_put doesn't exist - should I submit a PR for this patch libgit2/libgit2@a2012c4?
  • I'm seeing a bunch of LibGit2Sharp.EntryExistsException : A filter with the name 'cipher-filter' is already registered in tests - not sure what's changed - thoughts?

cc @ethomson

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions