Skip to content

Added BuildMultiTargeting props #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

devlead
Copy link
Contributor

@devlead devlead commented Sep 10, 2018

This makes this NuGet package compatible with multi targeted framework builds.

Testesd with and required for libgit2/libgit2sharp#1606

@bording
Copy link
Member

bording commented Sep 10, 2018

@devlead There's an easier way to handle this. Just have the buildMultiTargeting import the files from the build folder. That way they are static and never have to be updated.

@devlead
Copy link
Contributor Author

devlead commented Sep 10, 2018

True, good catch👍 I'll add an import and revert script change when I'm back at a computer.

@devlead devlead force-pushed the feature/MultiTargeting branch from 092b805 to 62757cd Compare September 15, 2018 10:29
@devlead
Copy link
Contributor Author

devlead commented Sep 15, 2018

@bording thing I've addressed your feedback, PR

Tried libgit2/libgit2sharp#1606 with https://ci.appveyor.com/project/devlead/libgit2sharp-nativebinaries/build/1.0.2/artifacts and it still compiles 😉

@bording bording merged commit 918aae5 into libgit2:master Sep 17, 2018
alex-weaver pushed a commit to alex-weaver/libgit2sharp.nativebinaries that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants