Add modf() in math module #458
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
reviewed
May 11, 2022
czgdp1807
reviewed
May 11, 2022
|
@Aasthaengg -- we can complete this now. Would you like to? |
namannimmo10
force-pushed
the
math_funcs_tuple
branch
from
7bb250c to
68758ab
Compare
namannimmo10
force-pushed
the
math_funcs_tuple
branch
from
68758ab to
6084f51
Compare
|
This is good, but can you please keep the original author in at least one of the commits? That way we credit the work that was done, which is very important. You can also keep the original commits and then submit commits to fix it, whichever way you want to do it. |
|
Right, I wanted to do that. Did a squash and merge -- added @Aasthaengg as a co-author. |
|
That works, perfect! Thanks for finishing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to use
modf()function inmathmodule. It compiles fine withpythonbut gives a compilation error withlpythonas pointed out in #457.