[Demo] Having LibASR at src/libasr/src/libasr
#2835
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CMakeLists.txt
ubaidsk
commented
Mar 29, 2025
| @@ -25,6 +25,8 @@ | |||
|
|
|||
|
|
|||
| TESTER_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__))) | |||
| if "src/libasr/src/libasr" in TESTER_DIR: | |||
| TESTER_DIR = TESTER_DIR.replace("src/libasr", "", 1) | |||
There was a problem hiding this comment.
This seems hackish and would get contributed to LFortran. Are we happy with this change going to LFortran?
(We can probably make this look more professional, for example using something like
subprocess.run("git rev-parse --show-toplevel" to get the project root directory and then updating the SRC, LIBASR_DIR, TESTER_DIR according to it).
ubaidsk
force-pushed
the
ubaid/test/libasr-src-libasr
branch
from
e68d580 to
4af7bb1
Compare
|
The other PR #2836 has been merged. Hence closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does no LibASR sync. It does no submodule related work. It merely changes the
src/libasrlocation tosrc/libasr/src/libasrwhich I believe would be the new location of libasr when submodule is added.