ASR: Allow variable access from module using dot #1243
Conversation
| ASR::symbol_t *sym = import_from_module(al, m, current_scope, value, | ||
| x.m_attr, x.m_attr, x.base.base.loc); | ||
| LFORTRAN_ASSERT(ASR::is_a<ASR::ExternalSymbol_t>(*sym)); | ||
| current_scope->add_symbol(x.m_attr, sym); |
There was a problem hiding this comment.
What if its already imported and added? We will add it to the current scope even though its already there?
There was a problem hiding this comment.
I think that here we should change the name of the symbol too. If we are already using some variable with the same name then it might be a conflict, for example:
import math
def f():
pi: f64 = 4.5030
print(math.pi, math.e)
f()This gives an error:
semantic error: pi already defined
To tackle this, we need to change the symbol name to module_name@attr_name.
We will add it to the current scope even though its already there?
import_from_module ensures that the symbol is not present in the current_scope.
There was a problem hiding this comment.
To tackle this, we need to change the symbol name to
module_name@attr_name.
Correct, name mangling is needed here I think. @certik Thoughts?
import_from_moduleensures that the symbol is not present in thecurrent_scope.
Please test this. Try using math.pi twice.
Fixes #1242