Skip to content

Fix some parser related issues #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 23, 2022
Merged

Fix some parser related issues #1141

merged 5 commits into from
Sep 23, 2022

Conversation

Thirumalai-Shaktivel
Copy link
Collaborator

No description provided.

@Thirumalai-Shaktivel Thirumalai-Shaktivel added the Parser Issues or improvements related to parser label Sep 23, 2022
@Thirumalai-Shaktivel
Copy link
Collaborator Author

Thirumalai-Shaktivel commented Sep 23, 2022 •
edited
Loading

I compared all the files (LPython AST vs CPython AST) in the LPython repository. These PR are the fixes for those which didn't match.
There is only one file which we should fix:

lpython/tests/parser/conditional_expr1.py

Lines 61 to 62 in 973438f

# FIXME: Generated AST is not similar to CPython Parser
chunks = [b'z' if cond1 else b'y' if cond2 else x for word in words]

which is related to the precedence

@Thirumalai-Shaktivel Thirumalai-Shaktivel merged commit e9709af into lcompilers:main Sep 23, 2022
@Thirumalai-Shaktivel Thirumalai-Shaktivel deleted the fix_parser branch September 23, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
Parser Issues or improvements related to parser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thirumalai-Shaktivel @certik