Remove ttype enum_type from EnumName and EnumValue
#1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
reviewed
Sep 23, 2022
| } | ||
| ASR::symbol_t* enum_type_cand = ASR::down_cast<ASR::symbol_t>(s_var->m_parent_symtab->asr_owner); | ||
| LFORTRAN_ASSERT(ASR::is_a<ASR::EnumType_t>(*enum_type_cand)); | ||
| return ASR::down_cast<ASR::EnumType_t>(enum_type_cand); |
There was a problem hiding this comment.
This PR is fine. Keeping the type in EnumName/Value would simplify this function, but otherwise it seems it's not needed that much.
I still don't like how complicated this function is, it feels like we are lumping together some unrelated things.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1117 (comment)