-
Notifications
You must be signed in to change notification settings - Fork 171
Improve C++ codegen by using last precedence #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
You have to update test results. |
@namannimmo10, if you want, you can try to finish this one. It shouldn't be difficult. |
I'll try to complete this one soon. |
Ready? Thanks for your comments! |
I haven't gone over the other expr visitors, but we need to carefully go over every expr visitor and ensure we assign to |
Last minor update I found. After that, do you mind rebasing this PR to a more logical set of commits? It looks like we don't have any comments, we always assign the last precedence, so you can probably squash the last few commits together and rewrite the commit log. |
4ef8f6a
to
0ad0add
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great, thanks! After this is merged, I'll port it to LFortran where we have a lot more C++ tests and if there are any bugs, I'll report back.
No description provided.