Skip to content

Fixes AuthenticatesUsers always force remember me #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth-backend/AuthenticatesUsers.php
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ protected function validateLogin(Request $request)
protected function attemptLogin(Request $request)
{
return $this->guard()->attempt(
$this->credentials($request), $request->filled('remember')
$this->credentials($request), $request->boolean('remember')
);
}

Expand Down
58 changes: 58 additions & 0 deletions tests/AuthBackend/AuthenticatesUsersTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,12 @@

namespace Laravel\Ui\Tests\AuthBackend;

use Illuminate\Auth\Events\Attempting;
use Illuminate\Foundation\Auth\AuthenticatesUsers;
use Illuminate\Http\Request;
use Illuminate\Routing\Pipeline;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Event;
use Illuminate\Testing\TestResponse;
use Illuminate\Validation\ValidationException;
use Orchestra\Testbench\Factories\UserFactory;
Expand Down Expand Up @@ -35,18 +37,74 @@ protected function defineDatabaseMigrations()
/** @test */
public function it_can_authenticate_a_user()
{
Event::fake();

$user = UserFactory::new()->create();

$request = Request::create('/login', 'POST', [
'email' => $user->email,
'password' => 'password',
], [], [], [
'HTTP_ACCEPT' => 'application/json',
]);

$response = $this->handleRequestUsing($request, function ($request) {
return $this->login($request);
})->assertStatus(204);

Event::assertDispatched(function (Attempting $event) {
return $event->remember === false;
});
}

/** @test */
public function it_can_authenticate_a_user_with_remember_as_false()
{
Event::fake();

$user = UserFactory::new()->create();

$request = Request::create('/login', 'POST', [
'email' => $user->email,
'password' => 'password',
'remember' => false,
], [], [], [
'HTTP_ACCEPT' => 'application/json',
]);

$response = $this->handleRequestUsing($request, function ($request) {
return $this->login($request);
})->assertStatus(204);

Event::assertDispatched(function (Attempting $event) {
return $event->remember === false;
});
}



/** @test */
public function it_can_authenticate_a_user_with_remember_as_true()
{
Event::fake();

$user = UserFactory::new()->create();

$request = Request::create('/login', 'POST', [
'email' => $user->email,
'password' => 'password',
'remember' => true,
], [], [], [
'HTTP_ACCEPT' => 'application/json',
]);

$response = $this->handleRequestUsing($request, function ($request) {
return $this->login($request);
})->assertStatus(204);

Event::assertDispatched(function (Attempting $event) {
return $event->remember === true;
});
}

/** @test */
Expand Down