[1.x] Add mariadb driver support plus Laravel 11 CI tests
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
laravel-11-ci
branch
from
586c8cc to
be21f9a
Compare
jessarcher
force-pushed
the
laravel-11-ci
branch
from
be21f9a to
a641624
Compare
jessarcher
changed the title
mariadb driver support plus Laravel 11 CI tests
timacdonald
approved these changes
Mar 13, 2024
jessarcher
commented
Mar 13, 2024
Comment on lines
+66
to
+69
| DB_DATABASE: pulse | ||
| DB_USERNAME: pulse | ||
| DB_PASSWORD: password | ||
| DB_COLLATION: utf8mb4_unicode_ci |
There was a problem hiding this comment.
Setting the credentials explicitly instead of relying on the defaults which recently changed.
The collation needs to be explicitly included here because the default collation is not supported on MySQL 5.7 where these tests are running.
jessarcher
commented
Mar 13, 2024
Comment on lines
-71
to
+76
| image: mariadb:10.5 | ||
| image: mariadb:10 |
There was a problem hiding this comment.
It seems MariaDB 10.5 doesn't support the new default collation. Rather than customize the collation here, I've opted to match the framework's CI tests and specify 10, which would give us MariaDB 10.6.
Is this still the case after this PR? |
|
@francoism90 no MariaDB was added in here. I'll PR that to the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub actions had started failing, which appears to be because we were relying on default
DB_env vars and/or default config file vars which have changed.This PR:
mariadbdatabase driver, which, in addition to being nice to have, also solved an issue with different default collations.