[7.x] Consistent filename #5920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

taylorotwell merged 1 commit into laravel:7.x from robin-dongbin:7.x

Mar 27, 2020

robin-dongbin commented Mar 27, 2020

We should keep consistent filename both in artisan make:model Model -a and artisan make:seeder Seeder.
Or edit the source code:
https://github.com/laravel/framework/blob/095ab36cabb942301ddc2060b3dbf1550474f4d8/src/Illuminate/Foundation/Console/ModelMakeCommand.php#L112


          consistent file name

8f3009a

driesvints changed the title ~~consistent filename~~ [7.x] Consistent filename

Member

driesvints commented Mar 27, 2020

We'll need to update the skeleton as well then.

Author

robin-dongbin commented Mar 27, 2020

@driesvints
Sorry, I can't understand your comment.
Is there anything else I need to do?

Member

driesvints commented Mar 27, 2020

@winter-ice https://github.com/laravel/laravel/blob/master/database/seeds/DatabaseSeeder.php#L14

Author

robin-dongbin commented Mar 27, 2020

Should I make a PR for this?

Member

driesvints commented Mar 27, 2020

Let's wait and see if this one gets accepted first

taylorotwell merged commit 3f7dd37 into laravel:7.x

robin-dongbin mentioned this pull request

[7.x] Consistent filename laravel/laravel#5271

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet