Skip to content

docs: update the readme to note Google provided integrations #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

averikitsch
Copy link
Collaborator

No description provided.


Learn how to use the [`PGVector` vectorstore](https://github.com/langchain-ai/langchain-postgres/blob/main/examples/vectorstore.ipynb).

## Google Cloud Integrations
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 requests:

  1. Could you add the standard test suite to the google packages and confirm that they pass the tests? It should be very quick to confirm and run the tests (~8 lines of code).

https://github.com/langchain-ai/langchain-postgres/blob/main/tests/unit_tests/test_vectorstore_standard_tests.py

  1. Could you document the lack of db agnostic filtering support? it's a feature a lot of users look for (easy filtering). I think if we're recommending something from this package, users will likely expect feature parity

Copy link
Collaborator Author

@averikitsch averikitsch Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We will have to make a few updates to our vector store ie support the method (a)get_by_ids() and support Document id fields and in metadata.
  2. I have added the note in the Readme. We will also look to support this

@efriis efriis self-assigned this Dec 13, 2024
@efriis
Copy link
Contributor

efriis commented Dec 13, 2024

@averikitsch could you confirm those tests are in and passing? If so happy to merge, otherwise will probably close until they do!

We also have a guide on implementing them now: https://python.langchain.com/docs/contributing/how_to/integrations/standard_tests/

@ccurme
Copy link
Contributor

ccurme commented Dec 18, 2024

Closing but will re-open pending response from @averikitsch.

@ccurme ccurme closed this Dec 18, 2024
@averikitsch
Copy link
Collaborator Author

I will re-open this PR when we have updated the test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants