Dev #8
Dev #8
Conversation
| const val matchResultTurboString = "\"content\":" |
There was a problem hiding this comment.
Sorry for the confusion my commit not clear. I have stored a val in here and made a push but found out it is not a good idea and removed it that is why noting has been changed in here.
| @@ -5,5 +5,5 @@ import com.chatgptlite.wanted.models.ConversationModel | |||
| interface ConversationRepository { | |||
| suspend fun fetchConversations() : MutableList<ConversationModel> | |||
| fun newConversation(conversation: ConversationModel) : ConversationModel | |||
| fun deleteConversation() | |||
| fun deleteConversation(index: Int) | |||
There was a problem hiding this comment.
I'd prefer to use conversationId, it will make sure which conversation is deleted than using index
There was a problem hiding this comment.
Yes, I got the feeling that would not be the best approach(The way I was thinking about this: If I add a new conversation and than try to delete after a sec this would require to recall the firebase to find the documentPath id to able to remove it). I have created this code before the message delete function where I'm using the conversationId to remove message from firebase. I will correct this. The project is very interesting thank you for sharing.
I added the following improvement to the project.
UI:
Code:
Pre-launch Checklist
Testcases covered (check if passed)
Screenshots (if change UI/UX)