perf: add shuffle_list
function
#744
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Shuffling a whole list should be much more efficient than calling
compute_shuffled_index
on every single item.Description
Lighthouse implementations claims it can be up to 250x more efficient than computing
compute_shuffled_index
through the entire list, see: https://github.com/sigp/lighthouse/blob/c11638c36c25f3af910eecd33a6e45d1caa99f1f/consensus/swap_or_not_shuffle/src/shuffle_list.rs#L55In my case I've observed "only" 10x improvements so far:
TODO: Integrate this function into the code.
Closes #467