perf: inline SszEx.hash function
#722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
commented
Feb 6, 2024
Comment on lines
+42
to
43
| # NOTE: the `Checkpoint` values in latest_messages are `LatestMessage`s | ||
| latest_messages: %{Types.validator_index() => Checkpoint.t()}, |
There was a problem hiding this comment.
I was puzzled by this when working on other things, so I added this comment
mpaulucci
reviewed
Feb 7, 2024
| @@ -18,6 +18,7 @@ defmodule LambdaEthereumConsensus.SszEx do | |||
| @zero_chunk <<0::size(@bits_per_chunk)>> | |||
| @zero_hashes ZeroHashes.compute_zero_hashes() | |||
|
|
|||
| @compile {:inline, hash: 1} | |||
mpaulucci
reviewed
Feb 7, 2024
| @@ -18,6 +18,7 @@ defmodule LambdaEthereumConsensus.SszEx do | |||
| @zero_chunk <<0::size(@bits_per_chunk)>> | |||
| @zero_hashes ZeroHashes.compute_zero_hashes() | |||
|
|
|||
| @compile {:inline, hash: 1} | |||
| @spec hash(iodata()) :: binary() | |||
There was a problem hiding this comment.
shouldnt this function live outside of SSZ? I see it's being used in other places too, like shuffling
There was a problem hiding this comment.
Maybe. We just added it here since adding a new module for this function seemed like too much
mpaulucci
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the function is just an "alias" to
:crypto.hash, we can safely inline all calls. This gives a ~5% performance increase when hashing, according to benchmarks.