Skip to content

docs: refine per-block-process design #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2024
Merged

docs: refine per-block-process design #702

merged 3 commits into from
Feb 5, 2024

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Feb 1, 2024 •
edited
Loading

After some feedback:

  • Removed the downloader task, it can be a block processor stage too. It removes one more passing around of the block and one more independent thing to take care about.
  • The GenServer now exits instead of waiting, and is respawned at a latter stage instead of receiving a message.
  • Some typos fixed.

@Arkenan Arkenan requested a review from a team as a code owner February 1, 2024 18:59
@Arkenan Arkenan changed the title Refine per-block-process design docs: refine per-block-process design Feb 1, 2024
MegaRedHand
MegaRedHand previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Arkenan @MegaRedHand
Update docs/concurrency_design.md
1a72821 
Co-authored-by: Tomás Grüner <47506558+MegaRedHand@users.noreply.github.com>
@Arkenan Arkenan merged commit 692da2a into main Feb 5, 2024
@Arkenan Arkenan deleted the refine-per-block-process-proposal branch February 5, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkenan @MegaRedHand