feat: wrap cgo Handles with Erlang Resources
#17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
force-pushed
the
use-resources
branch
from
08a693c to
672cab0
Compare
MegaRedHand
force-pushed
the
use-resources
branch
from
9ee1254 to
4f16ea2
Compare
NIFs keep a reference to the allocated resource by default on allocation. We need to release that reference before returning, otherwise it will never be GC'd.
MegaRedHand
force-pushed
the
use-resources
branch
from
3c4a907 to
4a4396a
Compare
Arkenan
approved these changes
Aug 9, 2023
avilagaston9
pushed a commit
that referenced
this pull request
Aug 9, 2024
# This is the 1st commit message: chore(deps): bump jason from 1.4.3 to 1.4.4 (#1243) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message #2: feat: add keystore API phoenix endpoint # This is the commit message #3: feat: add GET /keystores endpoint # This is the commit message #4: fix: update port flag # This is the commit message #5: feat: add post method # This is the commit message #6: refactor: validator manager genserver removal (#1244) # This is the commit message #7: refactor: save keystores into validators # This is the commit message #8: feat: add delete endpoint # This is the commit message #9: fix: delete/add endpoints # This is the commit message #10: fix: try fix ci # This is the commit message #11: fix: test # This is the commit message #12: refactor: enhace readability # This is the commit message #13: perf: compute all committees at once at the beginning of an epoch. (#1245) # This is the commit message #14: fix: use other validators slot when adding a new validator # This is the commit message #15: refactor: restore pruning # This is the commit message #16: Update README.md # This is the commit message #17: refactor: nit changes # This is the commit message #18: chore(deps): bump open_api_spex from 3.20.0 to 3.20.1 (#1252) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> # This is the commit message #19: chore(deps-dev): bump recode from 0.7.2 to 0.7.3 (#1251) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses Erlang's
Resources to bind the lifetime of a cgoHandleto its Elixir counterpart. This solves memory leak issues, while avoiding having to explicitly call destructors.