fix: recompute head was taking more than 20s in mainnet #1380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is possible that #1321 stop happening as usually as today, get_weight was called every time before, now is just used on a fork choice as it should. |
rodrigo-o
commented
Feb 5, 2025
Comment on lines
-29
to
-31
| |> then(fn | ||
| [] -> {:halt, head} | ||
| c -> {:cont, Enum.max_by(c, &get_weight(store, &1, justified_state))} |
There was a problem hiding this comment.
As we discussed with @ElFantasma this could have been just 1 line change like:
|> then(fn
[] -> {:halt, head}
[single_child] -> {:cont, single_child}
c -> {:cont, Enum.max_by(c, &get_weight(store, &1, justified_state))}most of the changes are just for readability
ElFantasma
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
It looks good to me.
I also think that your version has improved readability but I'd like some of the code authors' to take a look on the style change, to ensure they agree on that. Maybe @mpaulucci or @Arkenan ?
rodrigo-o
changed the title
|
Recompute head has been reduced from 20~30s to less than 1s Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Running the node for more than an epoch and just after block processing, 20+ seconds were taken before finishing the fork choice step, which made it impossible to execute sequentially inside the slot range (12s)
Description
After extensive debugging, the issue was found in the recompute head calculation, specially in the repeatedly call of get_weight where it wasn't really needed (outside of forks). The solution was taking into account this cases and stop calculating get_weight when encountered.
Resolves #1381