Skip to content

feat: assertoor implementation support #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Feb 3, 2025

Conversation

rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Oct 8, 2024

Motivation

Assertoor will allow us to have better regression checks when we tackle performance refactors

Description

Endpoints that needed fix/implementation for assertoor to work:

  • node/health - fixed
  • node/syncing - added (semi-stub)
  • beacon/genesis - fixed
  • configs/spec - added (semi-stub)
  • headers/head - added (semi-stub)
  • states/head/finality_checkpoints- fixed
  • events - This was implemented in feat: sse implementation for events beacon API #1365

Closes #1323

@rodrigo-o rodrigo-o mentioned this pull request Oct 17, 2024
2 tasks
@rodrigo-o rodrigo-o changed the title feat: assertoor implementation feat: assertoor implementation support Jan 24, 2025
@rodrigo-o rodrigo-o marked this pull request as ready for review January 30, 2025 21:15
@rodrigo-o rodrigo-o requested a review from a team as a code owner January 30, 2025 21:15
Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of suggestions on English redaction

rodrigo-o and others added 4 commits January 31, 2025 17:04
Co-authored-by: ElFantasma <estebandh@gmail.com>
Co-authored-by: ElFantasma <estebandh@gmail.com>
@rodrigo-o rodrigo-o merged commit 53c4585 into main Feb 3, 2025
14 checks passed
@rodrigo-o rodrigo-o deleted the initial-assertoor-implementation branch February 3, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Integrate Assertoor as part of the CI
2 participants