Skip to content

refactor: make BlockBySlot its own KvSchema #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 15, 2024
Merged

refactor: make BlockBySlot its own KvSchema #1217

merged 9 commits into from
Jul 15, 2024

Conversation

Arkenan
Copy link
Collaborator

@Arkenan Arkenan commented Jul 12, 2024 •
edited
Loading

Changes:

  • Added fold_keys function + option to include the starting key in KvSchema.
  • Added BlockBySlot module, implementing KvSchema. Includes tests.
  • Implement an all_present? function in BlockBySlot to check if a range of slots has all blocks available.
  • Made the BlockDb module use BlockBySlot instead of implementing all. Reduced code via KvSchema gets, puts, folds, removes.
  • Added tests for BlockDb behaviors that require block by slot like pruning.

Part of #1207

@Arkenan Arkenan changed the title Implement fold keys including the first value feat: make checkpoint sync asynchronous Jul 13, 2024
@Arkenan Arkenan changed the title feat: make checkpoint sync asynchronous refactor: make BlockBySlot its own KvSchema Jul 15, 2024
@Arkenan Arkenan marked this pull request as ready for review July 15, 2024 14:25
@Arkenan Arkenan requested a review from a team as a code owner July 15, 2024 14:25
avilagaston9
avilagaston9 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@avilagaston9 avilagaston9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Arkenan Arkenan merged commit e17070b into main Jul 15, 2024
13 checks passed
@Arkenan Arkenan deleted the async-checkpoint-sync branch July 15, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avilagaston9 avilagaston9 avilagaston9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Lambda Ethereum Consensus Node
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arkenan @avilagaston9