[release-0.7] Request mirroring conformance (#1912) #2034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add request mirror conformance tests * add more files * fix 2023 * added mirrored backend to the base manifests + added logs to ExpectedMirroredRequest * add newline * uncomment Suite Features * fix imports * remove mirrored-backend from base manifests and reuse existing infra-backend for conformance * add comment on controller-runtime
k8s-ci-robot
added
area/conformance-test
k8s-ci-robot
added
release-note
|
Thanks @LiorLieberman! Approving as this qualifies as "Additional conformance test coverage for existing features" per our versioning policy. Will defer to someone else for LGTM. /approve |
k8s-ci-robot
added
the
approved
robscott
changed the title
|
it is the exact same code that was merged to main. /cc @shaneutt |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LiorLieberman, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1912
cherry picking request mirroring conformance checks to 0.7.
Let me know if I did not do it correctly.
Does this PR introduce a user-facing change?:
/area conformance
/cc @robscott