Skip to content

Stabilize test failures #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vishesh92
Copy link
Member

Use correct version of providers in tests

Issue #, if available:

Description of changes:

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 8fdcaee
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/67e39721817ae200082a5e2f
😎 Deploy Preview https://deploy-preview-431--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishesh92 vishesh92 force-pushed the stabilize-test-failures branch from 308c24c to 32fc1fa Compare March 25, 2025 11:23
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.79%. Comparing base (d597e80) to head (8fdcaee).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   25.66%   25.79%   +0.12%     
==========================================
  Files          59       72      +13     
  Lines        5563     6742    +1179     
==========================================
+ Hits         1428     1739     +311     
- Misses       3996     4839     +843     
- Partials      139      164      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@blueorangutan
Copy link

Test Results : (tid-702)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.32.3
Kubernetes Version upgrade from: v1.31.7
Kubernetes Version upgrade to: v1.32.3
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr431-sl-702.zip



Summarizing 5 Failures:
 [FAIL] When testing multiple CPs in a shared network with kubevip [It] Should successfully create a cluster with multiple CPs in a shared network
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/controlplane_helpers.go:116
 [PANICKED!] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /root/sdk/go1.22.12/src/runtime/panic.go:261
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/node_helpers.go:56
 [FAIL] When testing clusters in a VPC network [It] Should successfully create a cluster in a VPC network with default offering
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/cluster_helpers.go:147
 [TIMEDOUT] When testing with disk offering [It] Should successfully create a cluster with disk offering
 /jenkins/workspace/capc-e2e-new/test/e2e/disk_offering.go:60

Ran 33 of 34 Specs in 10810.741 seconds
FAIL! - Suite Timeout Elapsed -- 28 Passed | 5 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (10810.74s)
FAIL

@blueorangutan
Copy link

Test Results : (tid-714)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.32.3
Kubernetes Version upgrade from: v1.31.7
Kubernetes Version upgrade to: v1.32.3
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr431-sl-714.zip



Summarizing 5 Failures:
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/node_helpers.go:56
 [PANICKED!] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /usr/local/go/src/runtime/panic.go:261
 [FAIL] When testing affinity group [It] Should have host affinity group when affinity is pro
 /jenkins/workspace/capc-e2e-new/test/e2e/common.go:372
 [FAIL] When testing resource cleanup [AfterEach] Should create a new network when the specified network does not exist
 /jenkins/workspace/capc-e2e-new/test/e2e/resource_cleanup.go:109
 [FAIL] When testing network with custom offering [BeforeEach] Should create a new network with a custom offering
 /jenkins/workspace/capc-e2e-new/test/e2e/network_with_custom_offering.go:66

Ran 33 of 34 Specs in 9141.380 seconds
FAIL! -- 28 Passed | 5 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (9141.38s)
FAIL

Use correct version of providers in tests
@vishesh92 vishesh92 force-pushed the stabilize-test-failures branch from 32fc1fa to 8fdcaee Compare March 26, 2025 05:56
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Mar 26, 2025
@vishesh92 vishesh92 requested review from rohityadavcloud and weizhouapache and removed request for davidjumani March 26, 2025 06:56
@blueorangutan
Copy link

Test Results : (tid-726)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.32.3
Kubernetes Version upgrade from: v1.31.7
Kubernetes Version upgrade to: v1.32.3
CloudStack Version: 4.20
Template: ubuntu-2404-kube
Jobs filtered by: (Should successfully upgrade kubernetes versions when there is a change in relevant fields|A node should be forcefully removed if it cannot be drained in time)
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr431-sl-726.zip



Ran 2 of 34 Specs in 2353.095 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 32 Skipped
PASS

@blueorangutan
Copy link

Test Results : (tid-727)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.32.3
Kubernetes Version upgrade from: v1.31.7
Kubernetes Version upgrade to: v1.32.3
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr431-sl-727.zip



Summarizing 1 Failure:
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/cluster_helpers.go:147

Ran 33 of 34 Specs in 8413.310 seconds
FAIL! -- 32 Passed | 1 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (8413.31s)
FAIL

@weizhouapache
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5976233 into kubernetes-sigs:main Mar 26, 2025
10 checks passed
@vishesh92 vishesh92 deleted the stabilize-test-failures branch March 26, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants