Skip to content

Fixup e2e test func errorExistsInLog #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

vishesh92
Copy link
Member

Issue #, if available:

Description of changes:

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 24, 2025
Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name Link
🔨 Latest commit 6a561cc
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/67e24854113f9e0008e8aff7
😎 Deploy Preview https://deploy-preview-428--kubernetes-sigs-cluster-api-cloudstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Mar 24, 2025
@vishesh92 vishesh92 requested review from weizhouapache and removed request for dims and chrisdoherty4 March 24, 2025 18:37
@vishesh92 vishesh92 marked this pull request as draft March 24, 2025 18:37
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 24, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.66%. Comparing base (d597e80) to head (56c8f5c).
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
- Coverage   25.66%   25.66%   -0.01%     
==========================================
  Files          59       72      +13     
  Lines        5563     6741    +1178     
==========================================
+ Hits         1428     1730     +302     
- Misses       3996     4846     +850     
- Partials      139      165      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vishesh92 vishesh92 force-pushed the fixup-log branch 2 times, most recently from 2971a6f to ae8c0e2 Compare March 25, 2025 06:07
@blueorangutan
Copy link

Test Results : (tid-686)
Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8
Kubernetes Version: v1.31.6
Kubernetes Version upgrade from: v1.30.10
Kubernetes Version upgrade to: v1.31.6
CloudStack Version: 4.20
Template: ubuntu-2404-kube
E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr428-sl-686.zip



Summarizing 2 Failures:
 [FAIL] When the specified resource does not exist When starting with a healthy cluster [It] Should fail to upgrade control plane machine due to insufficient compute resources
 /jenkins/workspace/capc-e2e-new/test/e2e/invalid_resource.go:260
 [FAIL] When testing node drain timeout [It] A node should be forcefully removed if it cannot be drained in time
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.9.6/framework/deployment_helpers.go:542

Ran 33 of 34 Specs in 8821.501 seconds
FAIL! -- 31 Passed | 2 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (8821.50s)
FAIL

@vishesh92 vishesh92 marked this pull request as ready for review March 25, 2025 09:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@weizhouapache
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from blueorangutan Mar 25, 2025
@vishesh92 vishesh92 removed the request for review from jweite-amazon March 25, 2025 10:04
@k8s-ci-robot k8s-ci-robot merged commit ad322bc into kubernetes-sigs:main Mar 25, 2025
10 checks passed
@vishesh92 vishesh92 deleted the fixup-log branch March 25, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants