Test if docs can be built #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Current coverage is 94.52% (diff: 100%)@@ master #96 diff @@
==========================================
Files 9 9
Lines 658 658
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 622 622
Misses 36 36
Partials 0 0
|
mbohlool
reviewed
Jan 12, 2017
| @@ -9,6 +9,7 @@ env: | |||
| - TOXENV=py27,codecov | |||
| - TOXENV=py27-functional,codecov | |||
| - TOXENV=py35-functional,codecov | |||
| - TOXENV=docs,codecov | |||
There was a problem hiding this comment.
do we need codecov for all of these? I think it will fail for doc or functional tests. Also we have a coverage env, maybe that is enough?
There was a problem hiding this comment.
yeah, i'll fix it in another PR @mbohlool
|
you have a conflict. I guess now that you are fixing the conflict you can remove all unnecessary codecov commands. Up to you though. this look good to me after fixing the conflict. |
mbohlool
added
the
lgtm
dims
force-pushed
the
enforce-doc-builds
branch
from
a2eb6c3 to
8d4cd14
Compare
|
Ack @mbohlool fixing it while i fix the conflicts in this PR |
|
@mbohlool - rebased. Let's get this in please. |
|
Great. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a travis job for docs. This will make sure we can catch if a PR is likely to break docs