Add functional test #94

dims · 2017-01-11T12:16:32Z

Port a bunch of tests from python-k8sclient repository. There is a script that starts a real instance of kubernetes and the tests are executed against it.

Note, if you just have k8s accessible in your localhost:8080, the tests still run. so you don't really need to run "py27-functional" which runs the kube-init.sh

Also, 2 API calls fail currently, i've added a TODO so we can dig into them and fix them

dims · 2017-01-11T14:13:56Z

@mbohlool ah looks like the TODO's i have here are stemming from the same bug already reported! #93

mbohlool · 2017-01-11T20:35:04Z

kubernetes/client/api_client.py

@@ -193,7 +193,7 @@ def sanitize_for_serialization(self, obj):
                    for sub_obj in obj]
        elif isinstance(obj, tuple):
            return tuple(self.sanitize_for_serialization(sub_obj)
-                for sub_obj in obj)
+                         for sub_obj in obj)


scripts/update-pep8.sh does not update this file. If this is the right style we should have, we need to be able to automate it there.

mbohlool · 2017-01-11T20:35:57Z

kubernetes/test/test_k8sclient.py

@@ -0,0 +1,204 @@
+# -*- coding: utf-8 -*-


the test folder will be removed and re-generated by scripts/update-client.sh. You need to either change the script there to keep this file or move this file to another folder. maybe put it in kubernetes/e2e_test folder or something like that? Also would be nice if we can have an script in scripts/ folder to deploy a minikube and run this against it.

Moved the file to e2e_test

mbohlool · 2017-01-11T20:37:22Z

scripts/kube-init.sh

@@ -0,0 +1,112 @@
+#!/bin/bash


add copyright header here.

mbohlool · 2017-01-11T20:38:27Z

scripts/kube-init.sh

+echo "K8S_VERSION : ${K8S_VERSION}"
+
+echo "Starting docker service"
+sudo systemctl enable docker.service


Is this supported on osx? if not, we should check at the start of script and fail for osx with a relevant message. it may not be hard to just support osx too.

This is mainly meant for travis. we can look into supporting other platforms. As mentioned, you really don't need this script, as long as you have localhost:8080 proxied to a working k8s instance for the tests to run.

Ignore all osx comments then now that I understand this is meant for travis.

mbohlool · 2017-01-11T20:39:16Z

scripts/kube-init.sh

+
+# Run the docker containers for kubernetes
+echo "Starting Kubernetes containers"
+sudo docker run \


most probably sudo is not necessary on osx.

This is working on travis. can tweak for OSX later

mbohlool · 2017-01-11T20:40:10Z

scripts/kube-init.sh

+        --allow-privileged=true --v=2
+
+
+echo "Download Kubernetes CLI"


we can first check if kubectl is available. if you want to always download an stable version, would suggest to download it in a temp folder and remove it at the end.

Ack. I can do this in a followup PR as this is mainly for the travis environment right now where we know kubectl is not available

this is for travis, no need to do so.

mbohlool · 2017-01-11T20:46:34Z

scripts/kube-init.sh

@@ -0,0 +1,112 @@
+#!/bin/bash
+


How/where do we use this file? If it is a manual run, it would be nice if we have an example here.

it's used when you run "tox -e py27-functional" so will run on travis

mbohlool · 2017-01-11T20:49:53Z

tox.ini

+commands = {toxinidir}/scripts/kube-init.sh nosetests []
+
+[testenv:coverage]
+commands = nosetests --with-coverage --cover-package=kubernetes.config,kubernetes.watch --cover-tests


I don't see code coverage comment from codecov-io. If we do the code coverage right, we should get such a comment. The comment look like this: #89 (comment)

Ack. i'll check on this

mbohlool · 2017-01-11T20:51:39Z

@dims I had some comment. Let me know if they make sense. I was looking into have some kind of e2e test from the beginning. This is great. Thanks.

codecov-io · 2017-01-12T00:02:41Z

Current coverage is 94.52% (diff: 100%)

Merging #94 into master will decrease coverage by 0.15%

@@             master        #94   diff @@
==========================================
  Files             9          9          
  Lines           658        658          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            623        622     -1   
- Misses           35         36     +1   
  Partials          0          0

Powered by Codecov. Last update ce8e082...010af62

mbohlool

One final comment, look good otherwise.

mbohlool · 2017-01-12T02:22:28Z

kubernetes/e2e_test/test_k8sclient.py

@@ -0,0 +1,204 @@
+# -*- coding: utf-8 -*-


would you please add copyright header to kubernetes/e2e_test/init.py file too. annoying but I think it is required on all files.

Done (added header to kubernetes/e2e_test/init.py

dims · 2017-01-12T03:15:59Z

ok @mbohlool - this is ready as well

mbohlool · 2017-01-12T06:51:39Z

@dims LGTM. please fix the conflict. thanks.

Port a bunch of tests from python-k8sclient repository. There is a script that starts a real instance of kubernetes and the tests are executed against it. Note, if you just have k8s accessible in your localhost:8080, the tests still run. so you don't really need to run "py27-functional" which runs the kube-init.sh Also, 2 API calls fail currently, i've added a TODO so we can dig into them and fix them

dims · 2017-01-12T11:42:46Z

@mbohlool Done!

…onfigs feat: merging kubeconfig files

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 11, 2017

mbohlool suggested changes Jan 11, 2017

View reviewed changes

dims force-pushed the add-functional-test branch 6 times, most recently from 2ac21d8 to 9a227d9 Compare January 11, 2017 23:08

dims force-pushed the add-functional-test branch 5 times, most recently from d3ae269 to 751dc40 Compare January 12, 2017 02:23

mbohlool suggested changes Jan 12, 2017

View reviewed changes

dims force-pushed the add-functional-test branch 4 times, most recently from 9a43721 to 00b2544 Compare January 12, 2017 03:03

mbohlool self-assigned this Jan 12, 2017

mbohlool approved these changes Jan 12, 2017

View reviewed changes

mbohlool added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2017

dims force-pushed the add-functional-test branch from 00b2544 to 010af62 Compare January 12, 2017 11:26

mbohlool merged commit c147f66 into kubernetes-client:master Jan 12, 2017

yliaog pushed a commit to yliaog/client-python that referenced this pull request Jan 8, 2022

Merge pull request kubernetes-client#94 from tomplus/feat/merge-kubec…

5c03b3b

…onfigs feat: merging kubeconfig files

Add functional test #94

Add functional test #94

Uh oh!

Conversation

dims commented Jan 11, 2017

Uh oh!

dims commented Jan 11, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbohlool commented Jan 11, 2017

Uh oh!

codecov-io commented Jan 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 94.52% (diff: 100%)

Uh oh!

mbohlool left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dims commented Jan 12, 2017

Uh oh!

mbohlool commented Jan 12, 2017

Uh oh!

dims commented Jan 12, 2017

Uh oh!

Uh oh!

codecov-io commented Jan 12, 2017 •

edited

Loading